-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak for async gzip #76
Comments
If there's a memory leak, I would think because you are holding on to the references to the stream outputs for too long. After processing a chunk, the async streams drop all references to it, as far as I can tell, but I'll investigate as well. Also, the second error looks more like an attempt to push the same Uint8Array to AsyncGzip that you use yourself. The docs mention that all pushed chunks are consumed in async streams (they become inaccessible after pushing). If you try to read from some data you've already pushed you may get this error. If it's actually from fflate, please send the full stack trace. |
Unfortunately the error is coming from an extension and is minified so hard to procude a readable trace.
Basically the function we've is: |
I suspect a memory leak since when i'm doing two runs and doing a memory compare it seems like a lot of retained buffers are still there. |
Still looking into this issue, maybe it applies to only a specific set of environments. What browser/engine are you using? |
Hey, we're still investigating on our end. might be an issue on our end. |
Uploading multiple files from a worker, creates a memory leak and eventually throws the following error:
"Cannot perform Construct on a detached ArrayBuffer"
Looking at the memory snapshot between two runs it seems like the created array buffers are not being cleaned after running the compress method
The text was updated successfully, but these errors were encountered: