Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

States without stroke... Brazil map only #228

Closed
wesleymacente opened this issue May 9, 2016 · 11 comments
Closed

States without stroke... Brazil map only #228

wesleymacente opened this issue May 9, 2016 · 11 comments

Comments

@wesleymacente
Copy link

wesleymacente commented May 9, 2016

The map of Brazil hasn't or almost hasn't a stroke/outline around states.
I tried to add outline options but not worked!
Are there any way to fix it?

captura de tela 2016-05-09 as 11 18 16

captura de tela 2016-05-09 as 11 18 28

@manifestinteractive
Copy link
Contributor

That certainly is weird. I tried this to and it did not work. It accepts the properties just fine so the issue is not in the javascript. Likely there is an issue with the map file itself. I will see if I can reach out to the original author of that file to see if they have any input on the issue.

@manifestinteractive
Copy link
Contributor

It looks like we had three versions of that brazil map.

What I could find regarding Pull Requests with that file changed was here:

https://github.com/manifestinteractive/jqvmap/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+brazil

The files appear to originate from Author @elmeerr back in 2013. You will likely need to reach out to him to recreate the file since he was the last one to touch it. It is definitely the map file though, after looking further into this. It does not appear to have been generated with region borders like the other map files.

Honestly not sure how that was never noticed until now.

@elmeerr
Copy link
Collaborator

elmeerr commented May 19, 2016

@wesleymacente @manifestinteractive Hi guys! To be honest, I don't even remember how I create this file...for me it was ok but now I see the difference. So...I'm trying to build another one but, as I said...I don't recall how I get the data from shapefile...I'm trying use SVG without success until now...

I'll keep trying to fix it and appreciate if you guys can give any help.

See you soon.

Kind regards.

@elmeerr
Copy link
Collaborator

elmeerr commented May 19, 2016

I'm back....now with the solution:

mapa_brazil

I think that is good now, right? I also improve the JS file and reduce it from +2mb to 145kb.

If everything is fine, I think you can close the issue.

Kind regards.

@wesleymacente
Copy link
Author

Olá @elmeerr. Dei uma olhada na sua atualização e realmente as linhas entre os estados melhorou!
No meu caso eu uso outras opções como estados inativos... mouseover e etc e notei que o mapa não funcionou com estes options.

Ah alguma forma de arrumar somente as linhas deixando os outros options funcionando?

Obrigado.

@elmeerr
Copy link
Collaborator

elmeerr commented May 19, 2016

@wesleymacente você tá querendo dizer que na outra versão do mapa você conseguia e nessa versão não consegue?

@wesleymacente
Copy link
Author

@elmeerr isso mesmo.

Assim:

captura de tela 2016-05-19 as 16 34 40

@elmeerr
Copy link
Collaborator

elmeerr commented May 19, 2016

@wesleymacente você pode colocar o exemplo do htmle do jsque você ta usando no Fiddle ou no CodePen para que eu possa ver o que ta acontecendo? Porque eu só alterei o arquivo que gera o desenho do mapa, as funções do mapa fazem parte do framework jquery.jqvmap.js...testei aqui e as funções estão funcionando normalmente.

@wesleymacente
Copy link
Author

wesleymacente commented May 20, 2016

@elmeerr
Copy link
Collaborator

elmeerr commented May 20, 2016

Oi @wesleymacente acho que o problema é porque atualizei também os códigos dos estados. Invés dos "br-xx" agora é só usar as siglas dos estados mesmo. Testa aí e me avisa. Flw.

@wesleymacente
Copy link
Author

Nossa.. que mancada!
Perfeito @elmeerr ... vc arrumou os strokes e ainda facilitou na nomeação dos estados!

Vlw dmais!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants