Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【BUG】软件重命名失效 #10

Closed
ifwlzs opened this issue Aug 4, 2021 · 3 comments
Closed

【BUG】软件重命名失效 #10

ifwlzs opened this issue Aug 4, 2021 · 3 comments

Comments

@ifwlzs
Copy link

ifwlzs commented Aug 4, 2021

经过多个小时的测试和排查,在我和 @olixina 不懈努力下,找到了无法重命名的原因。


问题分析:

gedoor-Build/action_app_custom.sh 文件下,第十六行的判断出现了问题

if [[ "$APP_NAME" == "legado" ]] && [[ "$SECRETS_RENAME" == "true" ]]; then

执行判断时,前半句是对的,后半句因为 $SECRETS_RENAME 变量未定义初始值,导致判断结果永远非true非false


解决方案:

$SECRETS_RENAME 变量赋予true初始值,可以看 @olixina 的修改记录

https://github.com/olixina/gedoor-Build/commit/8447fdf8b2bd89048b12ed95be7dc3e6cb894b01

@10bits
Copy link
Owner

10bits commented Aug 7, 2021

https://github.com/ifwlzs/gedoor-Build/settings/secrets/actions

这里增加一个secrets环境变量

RENAME=true

@ifwlzs
Copy link
Author

ifwlzs commented Aug 8, 2021

https://github.com/ifwlzs/gedoor-Build/settings/secrets/actions

这里增加一个secrets环境变量

RENAME=true

请问下,asset_path应该填什么内容

@10bits
Copy link
Owner

10bits commented Aug 9, 2021

apk路径,脚本会自动查找,如果有就上传release

@10bits 10bits closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants