INT-1838/INT-1872: Refactoring CRUD to BEM and Fixing Styles. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
INT-1838
branch
3 times, most recently
from
134f190
to
fd9a1dd
Compare
|
It looks great in the read-only view but in "edit mode" the carets are not indented with the rest of the line.
|
|
@marcgurney I did that on purpose - I thought we wanted to keep the carats in the gutter in edit mode but indent the rest. That was one of the main reasons for the refactoring I thought since it wasn't possible before with the previous layout and styles. |
|
No, we wanted to keep the (x) button always in the gutter, but not the carets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is