COMPASS-341 - Hide intercom widget when feedback disabled #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed https://jira.mongodb.org/browse/COMPASS-516 for follow-up discussion. |
|
Backported to 1.5-releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So according to Intercom support, window.Intercom('hide/show') does not hide/show the widget, only the messages. Right now there is a workaround that directly hides the element, but I'm not sure if this is the best solution. I've tried hooking into the 'hide'/'show' events and it didn't work, neither did a few other things I tried. I think we could do a refactor of how the metrics are handled, I find it a bit confusing that there is both an internal metrics package and an external one. Perhaps we should make a ticket for an improvement, and keep this as the bug ticket fix. Thoughts?