COMPASS-458 Decoupling and improving no collections visible message #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also only suggests to “Connect to another instance” link if the server is not a primary, which should make even more sense once COMPASS-288 (view replica set status info) is completed.
Design sprint will create their own ticket to iterate it, add 🎨, etc but the pieces should be there from dev for them to play with :)
Triple branch to get this right suggests I should push it downwards into its own component
|
@KeyboardTsundoku Thanks for reviewing, but your refactoring broke the |
|
@pzrq oh what, I thought I did a direct copy. Sorry about that 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not writable suggests
Connect to another instancezero state:Create Databasevisible zero state does not suggestConnect to another instance:Note: Could not get enzyme tests (not pushed) to work due to tight coupling with the
create-database-store.jsand other circular import issues, so happy to let this flow into the next sprint if we want to spend the time unit testing these components.See also #675