Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPASS-522: Validation style pass #683

Merged
merged 7 commits into from Dec 15, 2016

Conversation

Sean-Oh
Copy link
Contributor

@Sean-Oh Sean-Oh commented Dec 13, 2016

Some changes to clean up the Validation tab:

  • Changed input focus color from blue to green
  • Added missing placeholders
  • Reduced the height of the inputs / dropdown buttons; vertically centered their placeholders
  • Vertically centered the table rows
  • Made capitalization more consistent
  • Made trashcan button grey instead of red
  • Made dropdown + input form groups more unison
  • Other minor changes

screen shot 2016-12-13 at 12 00 55 pm

screen shot 2016-12-13 at 12 00 01 pm

screen shot 2016-12-13 at 12 00 17 pm

screen shot 2016-12-13 at 12 00 25 pm

screen shot 2016-12-13 at 12 02 34 pm

cc: @fredtruman

@fredtruman
Copy link
Contributor

Niiiice. Couple thoughts:

  • I think we want to keep the blue borders / focus style across the app for inputs. It used to be green but the thinking was that green implies "good" or "validated" whereas blue is more neutral.
  • Any chance you could align the button styles and the drop shadow more closely with Document CRUD styles? (less aggressive drop shadow, brown button text color) see:

screenshot 2016-12-13 12 54 03

@Sean-Oh
Copy link
Contributor Author

Sean-Oh commented Dec 13, 2016

@fredtruman Sure - I changed the form focus back to blue + made the cancel / update buttons similiar to the CRUD view + made span text italicized. What do you mean by less aggressive drop shadow though?

screen shot 2016-12-13 at 1 19 29 pm

@fredtruman
Copy link
Contributor

fredtruman commented Dec 13, 2016

The documents have box-shadow like:
box-shadow: 2px 5px 8px rgba(0,0,0,.2);

screenshot 2016-12-13 15 13 40

And the validator document has box-shadow like:
box-shadow: -10px 10px 50px -20px rgba(0,0,0,.75);

screenshot 2016-12-13 15 14 42

@Sean-Oh
Copy link
Contributor Author

Sean-Oh commented Dec 13, 2016

Changed!

@fredtruman
Copy link
Contributor

Nice! Look ok? 👀

@rueckstiess
Copy link
Member

@Sean-Oh @fredtruman The tests were failing because they assumed a certain capitalization which was changed as part of the style pass.

  1) <RangeInput /> when rendering the default control has placeholder text of `lower bound`:
      AssertionError: expected 'Lower bound' to equal 'lower bound'
      + expected - actual
      -Lower bound
      +lower bound
      
      at Context.it (test/validation.range.test.js:25:37)
  2) <RangeInput /> when rendering an upperBound control has placeholder text of `upper bound`:
      AssertionError: expected 'Upper bound' to equal 'upper bound'
      + expected - actual
      -Upper bound
      +upper bound

I'm going to rebase this branch and fix the failing tests accordingly.

@rueckstiess rueckstiess force-pushed the COMPASS-522-ValidationStylePass branch from 611095b to 4709f84 Compare December 15, 2016 06:32
@rueckstiess
Copy link
Member

LGTM.

@rueckstiess rueckstiess merged commit 6dcee06 into master Dec 15, 2016
@rueckstiess rueckstiess deleted the COMPASS-522-ValidationStylePass branch December 15, 2016 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants