COMPASS-468 schema shows undefined #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyasinha
force-pushed
the
COMPASS-468-Schema-Shows-Undefined
branch
from
496b634
to
510ef58
Compare
satyasinha
force-pushed
the
COMPASS-468-Schema-Shows-Undefined
branch
from
510ef58
to
02355d3
Compare
satyasinha
force-pushed
the
COMPASS-468-Schema-Shows-Undefined
branch
from
02355d3
to
ebc92ab
Compare
rueckstiess
changed the title
rueckstiess
reviewed
Dec 19, 2016
| // sets the active type to the first type in the props.types array | ||
| this.setState({ | ||
| types: types, | ||
| activeType: this.props.types.length > 0 ? this.props.types[0] : null |
There was a problem hiding this comment.
I think the selection of activeType needs to use types[0] here instead of this.props.types[0] otherwise it would still select Undefined if it had higher probability.
rueckstiess
previously requested changes
Dec 19, 2016
There was a problem hiding this comment.
Unfortunately still not working for me. Try with the dataset attached to ticket COMPASS-469.
|
|
||
| fieldProp.types = typesWithUndefined; | ||
| component = shallow(<Field {...fieldProp} />); | ||
| expect(component.find(Type).at(0)).to.have.data('tip', 'String (40%)'); |
There was a problem hiding this comment.
It also needs to test that the activeType (filled with the black bar) is String, not Undefined here.
satyasinha
force-pushed
the
COMPASS-468-Schema-Shows-Undefined
branch
from
ebc92ab
to
3dbb561
Compare
satyasinha
force-pushed
the
COMPASS-468-Schema-Shows-Undefined
branch
from
3dbb561
to
d69918a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made this pull request but I'm writing a couple of enzyme test cases for the schema view and can be reviewed after.