COMPASS-373: Don't report user errors as application errors #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
changed the title
|
👍 |
imlucas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does a few things:
It filters out all MongoErrors that would be sent to Intercom and Bugsnag to reduce clutter in these services. See: mongodb-js/metrics#15
Based on Bugsnag activity, the only MongoError that was not being displayed to the user when happening was an unauthorized count error from the documents tab... This is now displayed to the user as shown next:
This pull request also addresses the incorrect number of "documents loaded count in the documents list sampling message bar" when starting with less than 20 documents and inserting via Compass until the list goes over 20. Before, for example, when there were 20 documents and the user inserted 1 new document via Compass, the sampling message would display the correct count, but say "Viewing documents 1-41" when only 21 documents existed. Now this is fixed.
This pull also fixes the regression of retaining state of document element expansion. With the introduction of the expand all/collapse all functionality, the elements had lost their state when switching between view and edit modes. This is now resolved.
And last but not least, this pull also fixes COMPASS-529. When loading more documents, the
LoadMoreDocumentsStorenow is "filter aware" based on the new React query bar events.