COMPASS-543: Compass icon for Linux installers #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this hasn't been tested yet.
imlucas
changed the title
|
I can confirm this works:
Note that it does not update the screenshots in the Ubuntu Software Center (see http://askubuntu.com/questions/117130/how-to-include-a-screenshot-of-my-application-in-the-deb-ppa-to-show-it-in-softw ):
|
|
Tested with a combination of hadron-build@4.1.1 + COMPASS-546-linux-metadata, specifically 57ee4a0...dff2a4f so I think just waiting on Travis. |
|
LGTM thanks @rueckstiess 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux installers now include the Compass icon. Next sprint, we'll continue on this same work by making sure all application icons are set correctly for Linux. more details ›