New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPASS-546: Include Compass URL and email in Linux installers #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imlucas
changed the title
COMPASS-546 Linux package metadata (part 1)
COMPASS-546: Include Compass URL and email in Linux installers
Dec 20, 2016
rueckstiess
force-pushed
the
COMPASS-546-linux-pkg-meta
branch
from
December 21, 2016 00:27
c553137
to
dff2a4f
Compare
Rebased on current master. |
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Homepage https://github.com/unindented/electron-installer-redhat#optionshomepage https://docs.npmjs.com/files/package.json#homepage Note: I can’t actually find https://docs.mongodb.com/compass/ easily from https://compass.mongodb.com but we can resolve that separately as it’s not yet clear if we want to try to manage more than one homepage URL.
There is no authors AFAICT: https://docs.npmjs.com/files/package.json#people-fields-author-contributors
Hopefully avoids lintian error: The package is of bad quality The installation of a package which violates the quality standards isn't allowed. This could cause serious problems on your computer. Please contact the person or organisation who provided this package file and include the details beneath. Lintian check results for /home/mongo/Projects/compass/dist/mongodb-compass-dev_1~6~0-dev_amd64.deb: E: mongodb-compass-dev: maintainer-address-missing MongoDB Inc.
pzrq
force-pushed
the
COMPASS-546-linux-pkg-meta
branch
from
December 21, 2016 05:24
dff2a4f
to
e577faf
Compare
imlucas
approved these changes
Dec 21, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pzrq! I've updated the description and title to this PR as an example of the model we'd like to move toward.
Thanks @imlucas 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the metadata included in the Linux installers so they include a link to the Compass landing page on MongoDB.com and our compass@mongodb.com Intercom email inbox so customers on Linux can contact us directly with any questions or bug reports.