Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPASS-579: "Breadcrumb" Style Pass #711

Merged
merged 2 commits into from Dec 21, 2016
Merged

COMPASS-579: "Breadcrumb" Style Pass #711

merged 2 commits into from Dec 21, 2016

Conversation

fredtruman
Copy link
Contributor

@fredtruman fredtruman commented Dec 21, 2016

  • NOTE: Our link blue, used in the database and collection tables links is slightly off-putting when used aside our "compass blue" which is so dominant throughout the app. I would use "compass blue" for text links everywhere except it doesn't read well on white backgrounds. I think until we figure out a better palette using text links in regular linkText blue in our content areas and using "compass blue" for core navigation items is fine. Best shot.
  • Put an overflow on collection titles
  • Put cursors on any a:hover so non-hrefs will still get some affordance
  • The collection header styles (stats and h1) have always kind of bothered me as they get pretty thin and crunchy, especially on non-retina screens. I bumped the weight up on everything here. The hierarchy feels much better to me this way.

screenshot 2016-12-21 13 26 43

screenshot 2016-12-21 13 27 03

screenshot 2016-12-21 13 34 53

screenshot 2016-12-21 13 34 58

@KeyboardTsundoku
cc @Sean-Oh

@fredtruman fredtruman changed the title Compass-579: "Breadcrumb" Style Pass COMPASS-579: "Breadcrumb" Style Pass Dec 21, 2016
@durran
Copy link
Member

durran commented Dec 21, 2016

Yes! 👍

@durran durran merged commit 0e5afd4 into master Dec 21, 2016
@durran durran deleted the COMPASS-579 branch December 21, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants