COMPASS-392: Connect window sidebar styles #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredtruman
commented
Dec 21, 2016
| @@ -63,7 +63,7 @@ | |||
|
|
|||
| .list-group-item { | |||
| a { | |||
| padding: 2px 0px 6px 28px; | |||
There was a problem hiding this comment.
Can I get a screenshot? I left less padding on top since the majority of the visual weight lies in the hostname which should feel more vertically centered than the timestamp.
There was a problem hiding this comment.
Sorry, I just changed it to 5px.
We should revert this if you're not a fan, but I think it looks a bit funny when vertically uneven on hover. Otherwise this LGTM - a lot cleaner!
There was a problem hiding this comment.
localhost:27017 doesn't have any descenders so it feels more balanced. I would take it down to 3px or 4px padding on top max.
There was a problem hiding this comment.
k, I left padding as is and fixed the baseline overflow. 👍
rueckstiess
force-pushed
the
COMPASS-392
branch
from
9e00a9b
to
39cdd09
Compare
rueckstiess
force-pushed
the
COMPASS-392
branch
from
39cdd09
to
adf83c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I did not clean any of these styles up.
@Sean-Oh