New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPASS-584 hide system.* collections from table + refactoring #714
Conversation
This pull request fixes the basic issue of the system.version under the The current implementation makes all the links in the collection view not clickable/linkable if the current namespace is specialish. It does not pick individual names to not be clickable. So the question is should individual names be made clickable based on whether they're special or not? @rueckstiess @samweaver This may require a change in the ns module: https://github.com/mongodb-js/ns/blob/master/index.js#L32. Using |
Worked with Satya on the following changes:
|
Instead of being clickable or not, should we not just filter them out using the |
f8f5698
to
74a4b2f
Compare
@durran agreed, let's make it consistent with the sidebar. The property on which we filter collections out is actually |
LGTM (thanks for making this so much better @rueckstiess) |
…le table