Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPASS-584 hide system.* collections from table + refactoring #714

Merged
merged 6 commits into from Dec 28, 2016

Conversation

satyasinha
Copy link

…le table

@satyasinha
Copy link
Author

This pull request fixes the basic issue of the system.version under the admin tab being clickable (when it shouldn't be). However it also makes collections under local not clickable even though at the moment it can be viewed.

The current implementation makes all the links in the collection view not clickable/linkable if the current namespace is specialish. It does not pick individual names to not be clickable.

So the question is should individual names be made clickable based on whether they're special or not? @rueckstiess @samweaver

This may require a change in the ns module: https://github.com/mongodb-js/ns/blob/master/index.js#L32. Using this.database instead of this.collection Which would make collections of the form 'system'.x special.

@rueckstiess
Copy link
Member

Worked with Satya on the following changes:

  • "system" collections (namespace *.system.*) are not clickable anymore
  • all other collections are clickable
  • made table more generic again, removing assumptions of content
  • pass in links in the first column instead

@rueckstiess rueckstiess changed the title COMPASS-584 add a clickable prop to enable or disable links in sortab… COMPASS-584 make system.* collections not clickable, some refactoring Dec 23, 2016
@durran
Copy link
Member

durran commented Dec 26, 2016

Instead of being clickable or not, should we not just filter them out using the specialish attribute from mongodb-ns? I would expect to see the exact same collections in the sidebar as I do in the database tab.

@satyasinha satyasinha force-pushed the COMPASS-584-remove-special-links branch from f8f5698 to 74a4b2f Compare December 27, 2016 23:24
@rueckstiess rueckstiess changed the title COMPASS-584 make system.* collections not clickable, some refactoring COMPASS-584 hide system.* collections from table + refactoring Dec 28, 2016
@rueckstiess
Copy link
Member

@durran agreed, let's make it consistent with the sidebar. The property on which we filter collections out is actually .system, a much smaller subset of .specialish.

@satyasinha
Copy link
Author

LGTM (thanks for making this so much better @rueckstiess)

@satyasinha satyasinha merged commit b9595dc into master Dec 28, 2016
@satyasinha satyasinha deleted the COMPASS-584-remove-special-links branch December 28, 2016 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants