COMPASS-360: cancel empty validation rule #732
Conversation
satyasinha
changed the title
|
This commit fixes the issue in the ticket but there are other problems in the zero state for the Validation tab. The examples below show that the However, collectioninfo outputs for these collections via shell shows that they're not quite the same: Should this be clearer to the user? |
|
@KeyboardTsundoku just to check I understand: are you demonstrating here that a collection that doesn't have doc validation enabled appears the same in the UI as a collection that has it enabled with no rules? |
|
Yes, exactly! |
|
We can try something like this (with better styling) to represent blank option, maybe with a dash or completely blank option. |
|
Something similar would work - but lets not worry about it too much for now, the amount of times someone will encounter this is small. Lets close this out and open a new ticket for making OFF vs ON with no rules easier to interpret. |
| if (!_.has(this.lastFetchedValidatorDoc, 'validationAction') | ||
| && !_.has(this.lastFetchedValidatorDoc, 'validationLevel') | ||
| && _.isEmpty(this.lastFetchedValidatorDoc.validator)) { | ||
| state.editState = _.isEqual(this.lastFetchedValidatorDoc.validator, |
There was a problem hiding this comment.
since we just confirmed that this.lastFetchedValidatorDoc.validator is empty in the line above, it would be easier to just check if validatorDoc.validator is also empty, rather than compare the two. Makes it more readable, too.
satyasinha
force-pushed
the
COMPASS-360-cancel-empty-validation-rule
branch
from
8ffe819
to
1ddb062
Compare
|
LGTM. Will address the minor issue of empty validator doc vs. no rules present when the issue comes up. I don't think in practice it makes a difference. |
No description provided.