COMPASS-587: Improve the about Compass dialog

[pzrq]

The about dialog now looks correct and polished on all of our supported platforms. Two Linux compatibility issues have been fixed: the about dialog now shows the Compass icon instead of the system default and is now closable:

This also resolves a very long-standing annoyance reported by our Windows users way back in 2015.

Fixes COMPASS-587, COMPASS-352

[pzrq]

@durran If you could review this it would be appreciated.

Please let me know if you have any specific feedback, e.g. if I should do the Windows testing and post screenshots, also happy to let COMPASS-586 go through first and rebase accordingly if you've started on that.

[pzrq]

I finally figured out how to submit a patch to Evergreen via evergreen patch --project=10gen-compass-master --yes --finalize -v all -t all to see if I could get a Windows build to test, but got the error:

error: cannot apply binary patch to 'src/app/images/compass-dialog-icon.png' without full index line

https://evergreen.mongodb.com/task/10gen_compass_master_windows_64_compile_6eac6326bec13a93d9556b62c7ebfebedbac15a5_17_01_06_07_25_08

I guess the next step to try next week if this isn't yet merged will be evergreen patch-file ... with: http://stackoverflow.com/questions/17152171/git-cannot-apply-binary-patch-without-full-index-line

[rueckstiess]

@pzrq ask me about this again on Monday. patch-file is correct.

[pzrq]

patch-file did not work for me, what did from the Evergreen public wiki was:

evergreen patch --project=10gen-compass-master --yes --finalize -v all -t all \
-- --binary --full-index

Next step is to test in Windows VMs, then I'll update the initial post.
https://evergreen.mongodb.com/task/10gen_compass_master_windows_64_compile_ca10016a97d4106b8ed109569aabdb364df95a41_17_01_09_01_16_44

[pzrq]

Setting this back to Work in progress as the icon error from Red Hat 7 (non development box) also affected Windows 10. e.g. perhaps path must be constructed via path.join.

Of interest, suggesting it should work with a string path or NativeImage: electron/electron#4073

[pzrq]

OK I am now satisfied that the latest commit Windows/RedHat via Evergreen: Reuse RESOURCES path resolves the path issue on all supported platforms, setting to ready for review.

[imlucas]

LGTM. Thanks, @pzrq

[pzrq]

@imlucas 👍