Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spell Check action #247

Merged
merged 3 commits into from Aug 29, 2023
Merged

Add Spell Check action #247

merged 3 commits into from Aug 29, 2023

Conversation

mukeshpanchal27
Copy link
Member

Follow-up of #245

Added new CI for Spell Check that show error at the moment.

Checklist:

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review August 16, 2023 05:34
@joemcgill
Copy link
Member

Thanks @mukeshpanchal27. The output looks good, but it would be nice if these were all reported as warnings instead of causing the check to fail. Can you see if that's possible?

@mukeshpanchal27
Copy link
Member Author

Hello @joemcgill, it appears that the action didn't offer any configuration to generate warnings instead of errors. I've raised the issue and created a ticket here: crate-ci/typos#811 on the main repository. We will keep you posted once there are any updates on this matter.

@swissspidy
Copy link
Member

I think treating as errors is fine, but we should first merge that other PRs

@joemcgill
Copy link
Member

Thanks for checking, @mukeshpanchal27. Let's go ahead do what Pascal suggests, and merge the PR that fixes the current errors, and then merge trunk back into this PR to make sure we have things passing before merging this, so we don't introduce a blocker to other PRs.

@mukeshpanchal27
Copy link
Member Author

@joemcgill @felixarntz @swissspidy The PR is ready for review.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz felixarntz merged commit ba58d2e into trunk Aug 29, 2023
1 check passed
@felixarntz felixarntz deleted the add/spell-check-action branch August 29, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants