Add bio support to decouple the ssh client from std::net::TcpStream #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main commit is the first one
It adds a generic type to the ssh client, decoupling the structure from TcpStream to IO: Read + Write.
This allows the user to connect to the ssh server using different methods (e.g. WebSocket or some other proxies).
POC at here which works fine.
In order not to break the compatibility of the existing APIs, a new API
connect_bio
has been added which asks the user to provide its buffered input/output objects. Whereas the type-specific bindings for TcpStream were always established in the oldconnect
API.All the old examples work fine.
Add a new example to show how bio works.