New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Client and Stream #16

Closed

lbstr opened this issue Sep 17, 2020 · 1 comment

Contributor

lbstr commented Sep 17, 2020

I feel that these class names are too broad. In user code, you may have many clients, so you might have to do something like this:

import { Client as AlpacaClient } from '@master-chief/alpaca';

How about AlpacaClient and AlpacaStreamingClient? Or maybe AlpacaStreamer?

The text was updated successfully, but these errors were encountered:

Collaborator

117 commented Sep 17, 2020 •

edited

I like these.

AlpacaClient
AlpacaStream

117 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment