Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly reported filepaths causes hot reloading to never trigger #35

Closed
SiddharthSham opened this issue Jun 18, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@SiddharthSham
Copy link

While I suspect the issue to be specific to Windows, I have not tested on other platforms yet.

Within the reload method of the server, we expect the files to list out paths of the changed files.
On Windows, these paths use \\ as a delimiter sometimes, for example ./src\\views\\index.njk, while entry.inputPath uses a correctly normalised / delimiter - /src/views/index.njk.

This leads to a mismatch in the reload-client bundle, here, and thus always triggers a full refresh instead of morphing the DOM.

I'm unsure if this is related to a Windows user setting, or something handled internally by 11ty, but seems to be worth looking into!

@zachleat
Copy link
Member

I did just test this with the latest canary on my Windows laptop and was able to apply domdiff changes without full page refreshes—please let me know if you can still reproduce this with the latest versions!

This is an automated message to let you know that a helpful response was posted to your issue and for the health of the repository issue tracker the issue will be closed. This is to help alleviate issues hanging open waiting for a response from the original poster.

If the response works to solve your problem—great! But if you’re still having problems, do not let the issue’s closing deter you if you have additional questions! Post another comment and we will reopen the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants