Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected script interferes with the page and breaks it #39

Closed
pepelsbey opened this issue Jul 18, 2022 · 4 comments
Closed

Injected script interferes with the page and breaks it #39

pepelsbey opened this issue Jul 18, 2022 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@pepelsbey
Copy link

Gist

Shower presentation engine while served with eleventy-dev-server stops working properly after the first reload.

Steps to reproduce

  1. Install the server npm install -g @11ty/eleventy-dev-server
  2. Clone git@github.com:shower/shower.git
  3. Install dependencies npm install
  4. Run the server eleventy-dev-server
  5. Open http://localhost:8080/
  6. Click the first slide
  7. Press Right Arrow key a few times to reach the end
  8. Press Left Arrow key to go back
  9. Open index.html in editor and save it
  10. Try to navigate the slides, compare the behavior

Expected behavior

The same, before and after saving the file

Actual behavior

After the saving slides start to behave weird


11ty.mp4
@zachleat
Copy link
Member

I believe this is a duplicate of #7. I just filed what I think will be the follow-up issue there moving forward: #49

The workaround (for now) is to disable the domDiff feature.

@zachleat
Copy link
Member

I’m open to feedback about a breaking change to make domDiff: false the default too, hmm.

@zachleat zachleat added the duplicate This issue or pull request already exists label Jan 26, 2023
@pepelsbey
Copy link
Author

Thank you for following up! I think it would be safer to keep the diff disabled by default until you figure out how to make it work. Feel free to close this issue, I'm pretty sure it's a duplicate.

@zachleat
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants