Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM diffing does not work #48

Closed
chalkygames123 opened this issue Jan 25, 2023 · 4 comments
Closed

DOM diffing does not work #48

chalkygames123 opened this issue Jan 25, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@chalkygames123
Copy link

Hi,

I'm having fun trying this brand-new dev server and have encountered unexpected behavior.

Am I missing something?

What did I expect to happen:

Eleventy Dev Server that is bundled with Eleventy 2.0 will apply HTML changes without a full page reload.

What actually happened:

The server triggers a full page reload with an output "Page reload initiated." in the browser console when updating the input file, even if the domDiff option is enabled.

Steps to reproduce:

Create a new directory and then:

  1. Run npm install -DE @11ty/eleventy@2.0.0-canary.33
  2. Create index.html
  3. Run eleventy --serve
  4. Open localhost:8080 in your browser
  5. Edit and save index.html

Reproduction repo: https://github.com/chalkygames123/repro-eleventy-serve-dom-diffing

@zachleat zachleat added the bug Something isn't working label Jan 26, 2023
@zachleat zachleat self-assigned this Jan 26, 2023
@zachleat
Copy link
Member

You’re right! I’m on it.

@zachleat
Copy link
Member

Regression from #41

@zachleat
Copy link
Member

This will ship with Dev Server v1.0.2

@chalkygames123
Copy link
Author

It's fast! Thank you 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants