Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Audit: qs vulnerable to Prototype Pollution #2680

Closed
danielmatthew opened this issue Dec 7, 2022 · 3 comments
Closed

NPM Audit: qs vulnerable to Prototype Pollution #2680

danielmatthew opened this issue Dec 7, 2022 · 3 comments
Labels
bug: dependency A problem in one of Eleventy’s dependencies npm-audit Security audits from npm

Comments

@danielmatthew
Copy link

Describe the bug
Running npm audit against "@11ty/eleventy": "1.0.2" returns the following:

# npm audit report

qs  <6.2.4
Severity: high
qs vulnerable to Prototype Pollution - https://github.com/advisories/GHSA-hrpp-h998-j3pp
fix available via `npm audit fix --force`
Will install @11ty/eleventy@0.3.3, which is a breaking change
node_modules/qs
  browser-sync  >=2.12.1
  Depends on vulnerable versions of qs
  node_modules/browser-sync
    @11ty/eleventy  0.3.4 - 1.0.2
    Depends on vulnerable versions of browser-sync
    node_modules/@11ty/eleventy

To Reproduce

  1. Run npm audit

Environment:

  • OS and Version: macOS Ventura 13.0
  • Eleventy Version: 1.0.2

Additional context
Appreciate this also needs to be raised down the stack: I see "browser-sync": "2.27.10" was tagged in May, while the issue appears to be fixed in `"qs": "6.2.4".

@danielmatthew
Copy link
Author

BrowserSync/browser-sync#1821

Yikes.

@danielmatthew
Copy link
Author

@zachleat zachleat added bug: dependency A problem in one of Eleventy’s dependencies npm-audit Security audits from npm and removed needs-triage labels Dec 7, 2022
@zachleat zachleat added this to the Eleventy 1.0.x milestone Dec 7, 2022
@zachleat
Copy link
Member

This was fixed in browser-sync 2.27.11 which is compatible with our current versioning in both 1.x and 2.x (via eleventy-server-browsersync). Thank you!

@zachleat zachleat removed this from the Eleventy 1.0.x milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: dependency A problem in one of Eleventy’s dependencies npm-audit Security audits from npm
Projects
None yet
Development

No branches or pull requests

2 participants