Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance convenience and performance of DOM based transforms #3162

Closed
nhoizey opened this issue Jan 11, 2024 · 6 comments
Closed

Enhance convenience and performance of DOM based transforms #3162

nhoizey opened this issue Jan 11, 2024 · 6 comments
Labels
enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.

Comments

@nhoizey
Copy link
Contributor

nhoizey commented Jan 11, 2024

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

I hate to chain a sequence of transforms that all

  • read HTML, “load” is as a DOM, change some values, export to new HTML, then
  • read HTML, “load” is as a DOM, change some values, export to new HTML, then
  • read HTML, “load” is as a DOM, change some values, export to new HTML, then

Would it be possible to have a nicer experience by integrating the “read HTML, load is as a DOM” and “export to new HTML” steps inside 11ty, so that we only have to deal with the DOM?

It could use linkeDOM, which is much faster than Cheerio or other.

Describe alternatives you've considered

No response

Additional context

No response

@zachleat
Copy link
Member

Related #3194

@zachleat
Copy link
Member

Even more related #3199

@zachleat
Copy link
Member

Fwiw I do like the API Lume has here, though it’s probably not too fast.

https://lume.land/

image

@zachleat zachleat added needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. labels Jun 19, 2024
@zachleat
Copy link
Member

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.

View the enhancement backlog here. Don’t forget to upvote the top comment with 👍!

@zachleat zachleat closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@nhoizey
Copy link
Contributor Author

nhoizey commented Jun 19, 2024

I couldn't find any documentation about what #3199 provides to authors of plugins performing transforms.

Based on your latest comment about Lume's API, does it mean you're still considering different options, so it's not really available yet?

@zachleat
Copy link
Member

I’m doing some repo cleanup and putting non-3.0 milestoned enhancements into the enhancement queue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.
Projects
None yet
Development

No branches or pull requests

2 participants