Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the asterisks to the end of the field name #60

Closed
oeway opened this issue Jul 8, 2021 · 7 comments
Closed

Move the asterisks to the end of the field name #60

oeway opened this issue Jul 8, 2021 · 7 comments
Labels

Comments

@oeway
Copy link

oeway commented Jul 8, 2021

Hi, I got some feedback from some users, suggesting that the asterisks is a bit confusing.
Screen Shot 2021-07-08 at 8 25 14 PM

And I think it would be indeed nicer if we move the asterisks to the end of the field name (instead of the end of the explanatory sentence).

@14nrv
Copy link
Owner

14nrv commented Jul 8, 2021

Hi, I think it s confusing because the sentences are very long and not inside parenthesis compare to the CodeSandbox example:
Capture d’écran 2021-07-08 à 20 42 04

Perhaps you could simply "cheat", one more time, with the famous html :)
Adding a new props to this project, like hasAsteriskJustAfterLabel could be also an option.

@oeway
Copy link
Author

oeway commented Jul 8, 2021

Perhaps you could simply "cheat", one more time, with the famous html :)
Adding a new props to this project, like hasAsteriskJustAfterLabel could be also an option.

Right, but that's a bit hacky way of doing stuff, it doesn't feel right to have lots of html code embedded in js code. If possible, could you please have that implemented here? Either change it directly, or as an option.

@14nrv
Copy link
Owner

14nrv commented Jul 9, 2021

What do you think of adding a new props hasAsteriskJustAfterLabel like the other one that will be applied globally? The default value will be false.

@oeway
Copy link
Author

oeway commented Jul 9, 2021

the other one

Yes, that would work!

For custom field components (is: Component), can we also read these options somewhere?

@14nrv
Copy link
Owner

14nrv commented Oct 12, 2021

For custom field components (is: Component), can we also read these options somewhere?

I think yes because it s passed to the props formFields

@14nrv
Copy link
Owner

14nrv commented Oct 12, 2021

🎉 This issue has been resolved in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@14nrv 14nrv added the released label Oct 12, 2021
@14nrv 14nrv closed this as completed Oct 12, 2021
@oeway
Copy link
Author

oeway commented Oct 13, 2021

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants