Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with Work with us links #3797

Closed
brentryanjohnson opened this issue Jan 9, 2024 · 4 comments · Fixed by #3806
Closed

Accessibility issue with Work with us links #3797

brentryanjohnson opened this issue Jan 9, 2024 · 4 comments · Fixed by #3806
Assignees
Labels

Comments

@brentryanjohnson
Copy link
Member

Expected Behavior

  • Identical accessible names have identical href values

Actual Behavior

  • Identical accessible names have different href values

Proposed fixes

  • Pass a more descriptive accessible name that contains the visual text, in accordance with WCAG 2.2
  • Employ unique text for unique href values

Screenshot of error

The error was detected with GSA's AMP tool

Screenshot showing quick test result from Access assistant plugin with the text Work with us highlighted in green with an A and This A element has an accessible name that is the same as another A element but doesn't go to the same HREF

@dluetger
Copy link
Contributor

dluetger commented Feb 12, 2024

Do we know what the second link was with the same name? The "work with us" in the footer? If so, the only difference seems to be the menu one is implemented as a <span>, but they both go to the same place which is a shortcut back to this page.

Working on getting AMP access so I can replicate. WAVE doesn't see it, but will try some other tools

@dluetger
Copy link
Contributor

Okay, I think I see it. The one in the homepage subsection "What 18F can do" goes to "how we work" and not "work with us." Is it intentional the call to action here has the same text? I would have guesses the button said "How we work" to match it's destination. I'm thinking I'll make a PR for that change unless there are objections

@dluetger
Copy link
Contributor

Oh, "how we work" isn't even a page and redirects to "work with us" lol. So, yeah, I think the fix is on the homepage to make that third link match the rest as intended then :P

@dluetger dluetger linked a pull request Feb 13, 2024 that will close this issue
2 tasks
@dluetger
Copy link
Contributor

Got AMP access and was able to replicate. Annoyingly AMP does not show which links don't match and just throws all of them at you. Anyway, the preview page from the PR seems to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants