-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON encoding not specified #83
Comments
+1 this solution. The |
The dashboard gets JSON from S3 - the Express endpoints here are not currently used in production. This is a good note and we'll integrate the fix, but it won't resolve 18F/analytics.usa.gov#149. |
Won't S3 let you set the Content-Type header to include the encoding? |
@shawnbot It looks like the content encoding is getting set to https://github.com/18F/analytics-reporter/blob/master/bin/analytics#L42-L49 |
We should update the |
Yeah sorry, I meant that the |
Was this what you had in mind? #128 |
@jmhooper, @laurenancona, anyone else here - game to check if #128 resolved this issue? |
@gbinal: I believe it would have, but that is dead code now. |
Regarding a potential fix for 18F/analytics.usa.gov/issues/149, it looks like app/routes.js isn't specifying the character set for the returned JSON. Pulled from StackOverflow #16268244:
The text was updated successfully, but these errors were encountered: