Allow header disclaimer and logo to be skinned #1260
Conversation
webpack.config.js
Outdated
| mainFields: ['browserify', 'browser', 'module', 'main'] | ||
| mainFields: ['browserify', 'browser', 'module', 'main'], | ||
|
|
||
| symlinks: false |
There was a problem hiding this comment.
just curious why was this needed?
There was a problem hiding this comment.
This allows us to symlink our skin into the skins directory:
$ ls -l static_src/skins/
total 8
0 drwxr-xr-x 3 me staff 102 13 Oct 09:09 cg
8 lrwxr-xr-x 1 me staff 56 5 Oct 14:52 govau -> /Users/me/go/src/github.com/govau/ci-console/skin/
And we are symlinking (at the very least) for development: our skin is in another repo and I symlink it up.
Without this change, the UI won't build, giving the error:
ERROR in /Users/me/go/src/github.com/govau/ci-console/skin/index.js
Module build failed: ReferenceError: Unknown plugin "transform-object-rest-spread" specified in "base" at 0, attempted to resolve relative to "/Users/me/go/src/github.com/govau/ci-console/skin"
<omitted>
Upgrading babel and friends could fix this, but this config change does fix it and doesn't appear to affect anything else.
There was a problem hiding this comment.
thanks for that explanation! @jonathaningram could you make an issue to revisit this when babel is upgraded?
|
@jonathaningram LGTM. just a question |
|
[edit: Never mind, just saw the question you're referencing above in the review.] |
jonathaningram
force-pushed
the
ji-logo-skinning
branch
from
7420cb7
to
309f130
Compare
|
@jcscottiii rebased. Also I updated circle.yml (see 4822c34) to install latest chromedriver. I needed this to fix my failing integration tests for this PR (which worked locally). This hopefully also fixes flakiness as you can see in the failed master build: https://circleci.com/gh/18F/cg-dashboard/2654 |
A series of PRs from AusDTA are creating the concept of a skin within cg-dashboard As well as "templates" used by go components, there are js files consumed by the frontend. Here's DTA's current skin: https://github.com/govau/ci-console/tree/535b8fc466e42e20b22e11109c14ad5ee41a3561/skin Here are the PRs raised so far: cloud-gov/cg-dashboard#1259 (merged) cloud-gov/cg-dashboard#1260 (I'm basing my WIP off this)
If you're interested, see our matching PR that matches this change: govau/ci-console#3