This repository has been archived by the owner on May 19, 2020. It is now read-only.
Show domains and routes in app view #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2016 11:37
When an APP_RECEIVED event is fired, the app object that comes along with it contains all the route and domain information we need. So on that event, we can update the route store instead of only relying on sending a subsequent network request. If the app object doesn’t contain a child routes object then we will just ignore the event. Also changed the appGuid key in the route store to app_guid to be consistent with the kinds of data structures we keep in our stores.
Since we update the route store when an APP_RECEIVED event is fired, we don’t need an extra network request or action to get the routes for the application.
|
LGTM |
|
I don't have a good way to test this locally with my own cloud.gov account, since my local copy is just the test demo version, but it at least doesn't seem to introduce any new problems in what I can see. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
APP_RECEIVEDevent is fired, theappobject that comes along with it contains all the route and domain information we need. So on that event, we can update the route store instead of only relying on sending a subsequent network request. If theappobject doesn’t contain a childroutesarray then we will just ignore the event.Also changed the
appGuidkey in the route store toapp_guidto be consistent with the kinds of data structures we keep in our stores.Refs #468