This repository has been archived by the owner on May 19, 2020. It is now read-only.
427 marketplace #141
Merged
427 marketplace #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2015 14:39
Also made changes in the cf api tests to move similar functionality for the fetch error tests. This was done to reduce duplication.
I separated the service instance store and the service store to make the code easier to follow. The other alternative would be to make new getAll and get methods on the existing service store for instances vs services and store both in separate places which would be more code. This way keeps all stores in a similar state.
Notes: - Changed file name of ServiceInstanceList to service_instance_list because it's a more accurate name and allows a separate service_list file here. - Used the pattern of having a wrapper component that maintains state from store and would be call to fetch data because it's a good react practice and allows more separation. - Had to split the services response because that's how it wil come in from actual API.
| } | ||
|
|
||
| _handleDelete = (instanceGuid, ev) => { | ||
| ev.preventDefault(); |
There was a problem hiding this comment.
what does the preventDefault() do for the event?
There was a problem hiding this comment.
Prevent default ensures that the default action for the event doesn't happen. So if you have an a tag with a link, then the default action would be for the browser to go to the link. Prevent default will stop that from happening. In general, it's used to ensure browser consistent behavior, although often it's not strictly required.
This was added by mistake and not needed as the button is re-declared below.
| case serviceActionTypes.SERVICE_INSTANCES_RECEIVED: | ||
| var updates = this.formatSplitResponse(action.serviceInstances); | ||
| case serviceActionTypes.SERVICES_RECEIVED: | ||
| var updates = this.formatSplitResponse(action.services); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check commits for more information on decision making.