This repository has been archived by the owner on May 19, 2020. It is now read-only.
Individual pages #30
Merged
Individual pages #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code to fix repo rename
| @@ -1,6 +1,7 @@ | |||
| (function() { | |||
| // CloudFoundry Service | |||
| var cloudfoundry = function($http, $location) { | |||
| angular.module('cfconsole').service('$cloudfoundry', function($http, $location, $log) { | |||
added 10 commits
July 31, 2015 10:28
| @@ -22,7 +22,7 @@ | |||
| <div class="site-wrapper-inner"> | |||
| <div class="container"> | |||
| <!-- Where our view will load --> | |||
| <div ng-view></div> | |||
| <div ng-view ng-controller="DashboardCtrl"></div> | |||
There was a problem hiding this comment.
Why are you putting this into the base file and not the partials/index.html?
Current coverage is
|
|
@jcscottiii This should be done for now. The coverage on the front end dropped a little but we can add the small tests later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr - org data from the
/v2/organizationsendpoint is only loaded on entry, if prompted, or if an error occurs. This should keep costly api calls down especially when we create space/app/service pages.