Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Homepage content #430

Merged
merged 3 commits into from
Jul 7, 2016
Merged

Homepage content #430

merged 3 commits into from
Jul 7, 2016

Conversation

msecret
Copy link
Contributor

@msecret msecret commented Jul 6, 2016

Layout isn't great, might want to modify it a bit.

screen shot 2016-07-06 at 12 28 21 pm

@msecret
Copy link
Contributor Author

msecret commented Jul 6, 2016

Improved:

screen shot 2016-07-06 at 12 34 54 pm

Let's bring these into cg-style when we have the chance
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.958% when pulling fcc4c18 on ms-homepage_content into 76abf8b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.958% when pulling fcc4c18 on ms-homepage_content into 76abf8b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.958% when pulling c6c0f43 on ms-homepage_content into 76abf8b on master.

@brittag
Copy link
Contributor

brittag commented Jul 6, 2016

On a functionality + content level, this looks good to me! 🎉 (I'll leave checking the code to another person, if that needs to happen.)

@jeremiak
Copy link
Contributor

jeremiak commented Jul 7, 2016

Dependent on cloud-gov/cg-style#105 and probably also the release in cloud-gov/cg-style#106

@msecret
Copy link
Contributor Author

msecret commented Jul 7, 2016

It shouldn't be dependent on either of them, I did local styles

@jeremiak
Copy link
Contributor

jeremiak commented Jul 7, 2016

Ok, we can merge this and come back to clean it up with the next cg-style release. I made #435

@jeremiak jeremiak merged commit 4c2ff46 into master Jul 7, 2016
@jeremiak jeremiak deleted the ms-homepage_content branch July 7, 2016 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants