This repository has been archived by the owner on May 19, 2020. It is now read-only.
Allowing service destroyer to unbind apps and warn users #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geramirez
commented
Aug 13, 2015
geramirez
commented
|
@jcscottiii this should be done now. |
| it('hould put the available services into the app along with the boundService obj if it\'s bound', function() { | ||
| expect(scope.availableServices).toEqual([{metadata: { guid: 'serviceguid' }, boundService: { guid: 'serviceguid' }}]); | ||
| }); | ||
| it('hould put the available services into the app along with the boundService obj if it\'s bound', function() { |
|
your unit test for deleteServiceInstance should include a check that it shows the serviceInstances tab after completing successfully. Also, I'm completely fine with skipping that for now so that we can proceed onto other stories on the board as long as we put a TODO |
|
Needs to be rebased |
geramirez
force-pushed
the
delete-service-update
branch
from
6645cc6
to
85ae4de
Compare
|
@jcscottiii I've added a note to test the directive where those functions are located. |
jcscottiii
added a commit
that referenced
this pull request
Aug 17, 2015
Allowing service destroyer to unbind apps and warn users
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.