Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

user permission management #73

Merged
merged 39 commits into from
Aug 25, 2015
Merged

user permission management #73

merged 39 commits into from
Aug 25, 2015

Conversation

jcscottiii
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 93.27%

Merging #73 into master will decrease coverage by -1.39% as of f5961bc

@@            master     #73   diff @@
======================================
  Files            4       4       
  Stmts          281     431   +150
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            266     402   +136
  Partial          0       0       
- Missed          15      29    +14

Review entire Coverage Diff as of f5961bc

Uncovered Suggestions

  1. +1.39% via ...c/app/controllers.js#89...94
  2. +0.93% via ...c/app/controllers.js#76...79
  3. +0.70% via .../app/cloudfoundry.js#437...439
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

msecret
msecret reviewed Aug 17, 2015
View reviewed changes
static/app/controllers.js
app.controller('OrgManagementCtrl', function($scope, $cloudfoundry, $routeParams, MenuData) {
loadOrg(MenuData, $routeParams, $cloudfoundry, $scope);
var renderOrgUsers = function(users) {
console.log(users);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debug statements?

@jcscottiii
Copy link
Contributor Author

image

@jcscottiii
Copy link
Contributor Author

Still working on this

@jcscottiii
Copy link
Contributor Author

image

image

image

Need to switch from using invite by email to invite by username because multiple users can have the same email.

@jcscottiii jcscottiii force-pushed the userperm branch 2 times, most recently from 89b1705 to b99a75d Compare August 23, 2015 18:24
James C. Scott and others added 21 commits August 25, 2015 11:16
Added initial user management
45a3292
Added nice switches and org user page
547176d
Logic to watch slider.
f1ecf8b
Fixed tests dep
41c6cb3
Disable buttons until initial load has happened
7a65526
Disable when submitting a new change request
e2fdcf5
Disable org manager slider when loading
2b6273f 
previous commit disabled other two. this commit does so for the org
manager.
Added privilegedproxy for other user info (read-only)
01cc555
Basic ability to add external users to org
4881cdf
Basic ability to remove user from org
666d343
Invite user based on email
6c05f8f 
Need to change to userName because two users can have the same email
but not the same userName.
Moved to using username instead of email.
94d7301
go fmt update for uaa.go
9047a0f
Remove redundant code
99b165d
Add tests for privileged proxy
2fce805
Refactor go unit tests
a460b20
Fixed tests dep
c35f66a
making urls for space tabs
ab3f3e9
condensing html
be6872d
adding test coverage
1cb53ce
adding space user management methods and fixing tests
685f662
ramirezg and others added 18 commits August 25, 2015 11:21
adding navigation to user management
787b7cd
surfacing error messages
4d457a6
dividing current users list with potential users list
05bd5f9
Initial tests for uaa
3343c45
creating an activeSpace storage
a37f58f
More UAA tests.
7e41e23 
TODO need to clean up privileged tests
fixing documentation
d3bef73
javascript Ctrl tests for org management
d305426
Update to CFService tests
8a35365
Only show manage org is org manager
585dab8
Added privilegedproxy for other user info (read-only)
8e746fc
Invite user based on email
0e1eed1 
Need to change to userName because two users can have the same email
but not the same userName.
Refactor go unit tests
bdfe383
adding a pager get method
43b4c08
fixing controller tests
73c7856
fixing rebase
91b78ea
updating tests
224d539
Refresh page after changing org users
ea7cc67
jcscottiii added a commit that referenced this pull request Aug 25, 2015
@jcscottiii
Merge pull request #73 from 18F/userperm
4247700 
user permission management
@jcscottiii jcscottiii merged commit 4247700 into master Aug 25, 2015
@jcscottiii jcscottiii deleted the userperm branch August 28, 2015 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcscottiii @codecov-io @msecret