Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs around using HTTP-01 validation for LetsEncrypt #1422

Merged
merged 3 commits into from Apr 18, 2019

Conversation

bengerman13
Copy link
Contributor

HTTP-01 is currently broken, and not tested, so remove docs about using it

HTTP-01 is currently broken, and not tested, so remove docs about using
it
@siennathesane
Copy link

Let's reference that it's currently in a broken state and not actively tested instead of taking it down completely because we need to ensure we have incentive to fix it.

Also re-align sample output with actual output, since we haven't changed
it in the broker yet.
@bengerman13
Copy link
Contributor Author

@mxplusb sounds good. Updated with your recommendation.

Copy link

@siennathesane siennathesane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being nitpicky.

content/docs/services/cdn-route.md Outdated Show resolved Hide resolved
Copy link

@siennathesane siennathesane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bengerman13 bengerman13 merged commit f93fed4 into master Apr 18, 2019
@bengerman13 bengerman13 deleted the no-http-01-for-cdn-broker branch April 20, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants