This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
Encapsulate alternate address behavior #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds higher order component to supply necessary dependencies to wrapped components
el-mapache
force-pushed
the
ab-924-employment
branch
from
ec8a0b2
to
064a70e
Compare
el-mapache
force-pushed
the
ab-924-employment
branch
2 times, most recently
from
75dc9f8
to
46c246f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1113 +/- ##
===========================================
+ Coverage 47.01% 47.03% +0.02%
===========================================
Files 681 683 +2
Lines 27470 27487 +17
Branches 3403 3407 +4
===========================================
+ Hits 12914 12928 +14
- Misses 14196 14199 +3
Partials 360 360
Continue to review full report at Codecov.
|
el-mapache
changed the title
|
@el-mapache Still poking it, but here is one data point: If I add a self-employed entry, and enter an "Outside of the US" address for verifier, and then click "No" to following APO question, then:
|
|
Also:
But the residence verifier workflow looks good 👍 |
|
Thanks, working on fixing now! |
el-mapache
force-pushed
the
ab-924-employment
branch
2 times, most recently
from
9ad86fe
to
775e754
Compare
|
@ryanhofdotgov I think this should be good to go, thanks again for reviewing |
|
I'm seeing an odd problem, but have split if off into #1117 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #1107, #1108
AlternateAddressto employment and the reference address section of theHistorysubsection