Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

Add AlternateAddress to Relative/ForeignNational components #1126

Merged
merged 3 commits into from Nov 13, 2018

Conversation

el-mapache
Copy link
Contributor

@el-mapache el-mapache commented Nov 7, 2018

Fixes #753

@el-mapache el-mapache self-assigned this Nov 7, 2018
@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #1126 into develop will increase coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1126      +/-   ##
===========================================
+ Coverage    46.85%   46.86%   +0.01%     
===========================================
  Files          683      683              
  Lines        27562    27567       +5     
  Branches      3422     3424       +2     
===========================================
+ Hits         12913    12919       +6     
+ Misses       14291    14290       -1     
  Partials       358      358
Flag Coverage Δ
#backend 7.98% <ø> (ø) ⬆️
#frontend 90.21% <80%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...nents/Section/Foreign/Contacts/ForeignNational.jsx 82.66% <ø> (ø) ⬆️
src/schema/section/relationships-relatives.js 100% <ø> (ø) ⬆️
...nents/Section/Relationships/Relatives/Relative.jsx 90.09% <ø> (ø) ⬆️
src/schema/section/foreign-contacts.js 100% <ø> (ø) ⬆️
...onents/Section/Military/Foreign/ForeignContact.jsx 100% <ø> (ø) ⬆️
src/config/locales/en/address.js 100% <ø> (ø) ⬆️
...ents/Section/Relationships/Relatives/Relatives.jsx 100% <100%> (ø) ⬆️
...c/components/Section/Foreign/Contacts/Contacts.jsx 93.33% <100%> (+0.47%) ⬆️
src/components/Form/Location/AlternateAddress.jsx 82.75% <66.66%> (+5.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 198bab1...04e9dc5. Read the comment docs.

@el-mapache el-mapache changed the title (WIP) Add AlternateAddress to Relative component (WIP) Add AlternateAddress to Relative/ForeignNational components Nov 8, 2018
@el-mapache el-mapache changed the title (WIP) Add AlternateAddress to Relative/ForeignNational components Add AlternateAddress to Relative/ForeignNational components Nov 8, 2018
@ryanhofdotgov ryanhofdotgov merged commit b953b09 into develop Nov 13, 2018
@ryanhofdotgov ryanhofdotgov deleted the ab-753 branch November 13, 2018 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants