New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOLD: allow federalist operators to delete a site #2917
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no. the intent is to allow us to delete a site in Federalist app
…On Mon, Sep 14, 2020 at 1:25 PM David Corwin ***@***.***> wrote:
@amirbey <https://github.com/amirbey> The intent is for this feature to
be available in the admin UI only, correct?
cc @apburnes <https://github.com/apburnes>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2917 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJUBYVLN7EKXXWXRQFVZTDSFZGYZANCNFSM4RHXAJJA>
.
--
Amir Reavis-Bey
Product Lead for Federalist, TTS
amir.reavis-bey@gsa.gov
|
I thought we were doing the delete through the admin UI too. |
Me as well. My understanding is the Federalist operator can delete through
the app or the admin UI.
…On Mon, Sep 14, 2020 at 1:36 PM Andrew Burnes ***@***.***> wrote:
I thought we were doing the delete through the admin UI too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2917 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJUBYXCUPI2L33MVGIH3KLSFZIABANCNFSM4RHXAJJA>
.
--
Amir Reavis-Bey
Product Lead for Federalist, TTS
amir.reavis-bey@gsa.gov
|
let's touch base during stand
On Mon, Sep 14, 2020 at 10:37 AM Amir Reavis-Bey <notifications@github.com>
wrote:
… Me as well. My understanding is the Federalist operator can delete through
the app or the admin UI.
On Mon, Sep 14, 2020 at 1:36 PM Andrew Burnes ***@***.***>
wrote:
> I thought we were doing the delete through the admin UI too.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#2917 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAJUBYXCUPI2L33MVGIH3KLSFZIABANCNFSM4RHXAJJA
>
> .
>
--
Amir Reavis-Bey
Product Lead for Federalist, TTS
***@***.***
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2917 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABS2RY2GF57XHBHKO4P7E6DSFZIGHANCNFSM4RHXAJJA>
.
--
David Corwin
Federalist <https://federalist.18f.gov/> | Lead Engineer
david.corwin@gsa.gov
|
davemcorwin
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
amirbey
changed the title
allow federalist operators to delete a site
HOLD: allow federalist operators to delete a site
Sep 16, 2020
re-implemented #2929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.