Skip to content
This repository has been archived by the owner on Aug 27, 2019. It is now read-only.

make hoverable anchor links #35

Open
afeld opened this issue Jan 20, 2016 · 4 comments
Open

make hoverable anchor links #35

afeld opened this issue Jan 20, 2016 · 4 comments
Labels
enhancement question

Comments

@afeld
Copy link
Contributor

afeld commented Jan 20, 2016

Just incorporated http://bryanbraun.github.io/anchorjs/ to Before You Ship to be able to link to sections within the page (18F/before-you-ship#88), and it works really well. Thoughts about including it by default?
@mbland
Copy link
Contributor

mbland commented Jan 20, 2016

Sure, why not? Drop it into assets/js/vendor, update lib/guides_style_18f/includes/scripts.html, shoot me a PR. :-)

@afeld
Copy link
Contributor Author

afeld commented Feb 29, 2016

Closed by #37.

@afeld afeld closed this as completed Feb 29, 2016
@afeld
Copy link
Contributor Author

afeld commented May 3, 2017

Removed in #57 because of accessibility issues...would love to get them back again, with those fixed.

@afeld afeld reopened this May 3, 2017
@afeld afeld mentioned this issue May 3, 2017
Closed
@afeld
Copy link
Contributor Author

afeld commented Aug 22, 2017 •
edited

Seems there has been some work around this:

https://github.com/bryanbraun/anchorjs/issues?utf8=%E2%9C%93&q=accessibility

I wonder if we were using an old version? @nickbristow Any chance you (or someone from the Accessibility Guild) could re-review the plugin and see if there are any remaining accessibility blockers?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afeld @mbland