-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🟡 As a visitor, I can recognize where I am in relation to the whole page #282
Comments
If this enhancement is done, it should be implemented across all guides. |
@cantsin how large of a task is this? Low priority but if low effort then perhaps we pick it up |
Ooh if we do this, https://guides.18f.gov/engineering/tools/project-setup/ might be a good test page. it looks like USWDS uses javascript to add Maybe we can have an engineer pair with a designer on this one? |
That would be great to have a pairing ticket :) - moving this to candidate for prioritization |
If we discover a bug - consider an upstream bug fix :) |
I would stick with the bold active link style used in the example/screenshot above. I'm hesitant to suggest a new link style not already in the design system, in response to the issue's comment "Should we do something a bit more visible than the default darker gray/bold treatment for the active link" @caleywoods @bpdesigns (thoughts?) |
I agree unless there is a reason existing styles won't work |
@a-chappelear @bpdesigns @cantsin James, the USWDS GitHub link you listed is for the in-page navigation component which differs from the sidenav component. I dug into the USDS site and they have a https://sprint.usds.gov/assets/js/app.js - The odd bit here is I don't see this in their codebase (the file or the code) after spending a few minutes looking. Edit: Here's the code in |
No upstream bugfix here, the out of the box navigation highlight code works for the in page navigation component but the navigation component being used for the guides site (and most 11ty sites based on the original template used) is the side navigation component which doesn't support the highlighting out of the box. |
Background
![Screen Shot 2021-01-04 at 4 44 27 PM](https://user-images.githubusercontent.com/1080991/103582590-26f71300-4eac-11eb-973b-5d1613bb1bb1.png)
The USDS Discovery Sprint Guide, which also uses the Federalist template with sidenav, highlights the active sidenav section as you scroll. This would help our readers, particularly on our very long pages.
Should we do something a bit more visible than the default darker gray/bold treatment for the active link?
Acceptance criteria
Tasks
Definition of done
The text was updated successfully, but these errors were encountered: