Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Add jasmine tests to Travis #628

Closed
gemfarmer opened this issue May 31, 2016 · 3 comments
Closed

Add jasmine tests to Travis #628

gemfarmer opened this issue May 31, 2016 · 3 comments

Comments

@gemfarmer
Copy link
Contributor

I just noticed that the auctions/winners page is broken in prod, likely because the Jasmine tests aren't configured in Travis!

As a corollary to this Travis issue, all code should be updated so that the Jasmine tests pass. This will likely just mean renaming some methods in the JS, as there were several recent renaming PRs.

@jessieay
Copy link
Contributor

Can run jasmine with konacha https://github.com/18F/C2/blob/master/Rakefile#L11

@jessieay
Copy link
Contributor

jasmine ci may be best option (vai brian) https://github.com/jasmine/jasmine-gem#usage

@jessieay
Copy link
Contributor

jessieay commented Jul 7, 2016

this is done!

@jessieay jessieay closed this as completed Jul 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants