Skip to content
This repository has been archived by the owner on Nov 7, 2018. It is now read-only.

to improve indexing performance, we should let Elasticsearch do the update #267

Open
ultrasaurus opened this issue Jan 12, 2016 · 2 comments

Comments

@ultrasaurus
Copy link
Contributor

To implement nested documents, the current code fetches the whole document from Elasticsearch and then sends an update with a new document. This is highly inefficient, when es has the ability of updating a nested doc:

https://github.com/18F/open-data-maker/blob/dev/lib/data_magic/index.rb#L79-L85

@pkarman
Copy link
Contributor

pkarman commented Jan 12, 2016

@pkarman
Copy link
Contributor

pkarman commented Feb 18, 2016

I believe this is already implemented. When working on #295 I added a ES_DEBUG env variable and there is no ES fetch being performed. The ES update feature is already being used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants