Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Text in detail panel appears offscreen for bottom rows #455

Closed
jmcarp opened this issue Aug 11, 2015 · 2 comments
Closed

Text in detail panel appears offscreen for bottom rows #455

jmcarp opened this issue Aug 11, 2015 · 2 comments

Comments

@jmcarp
Copy link
Contributor

jmcarp commented Aug 11, 2015

When a user clicks on a table row to pull up the detail panel, the detail text appears at the top of the table. This looks good for rows toward the top of the table, but for rows toward the bottom, the detail text is offscreen, and the user has to scroll away from the highlighted row to see the text. To reproduce, go to the receipts page, scroll to the bottom, and click the last row in the table.
screen shot 2015-08-10 at 8 54 56 pm

Not sure how to resolve this--maybe the detail text should be anchored to the highlighted row somehow. What do you think @noahmanger @msecret @jenniferthibault?

@noahmanger
Copy link
Contributor

I've been wrestling with this and still can't figure it out. The way similar "master-detail" layouts like this work is that the master list on the left scrolls within its own container. So we'd set a max-height on the table with overflow-y: scroll that way the details panel on the right would always be visible.

The alternative would be to try something along the lines of having the details panel stick once it reaches the top of the screen, but that feels clunky to me.

@noahmanger
Copy link
Contributor

In a recent patch we made it so that when you open a panel, focus is set on the close icon. This has the side-effect of scrolling to the top of the page so you can see it. I think that works for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants