Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Consolidate filings columns #470

Closed
jmcarp opened this issue Aug 13, 2015 · 2 comments
Closed

Consolidate filings columns #470

jmcarp opened this issue Aug 13, 2015 · 2 comments
Assignees
@jmcarp

Comments

@jmcarp
Copy link
Contributor

jmcarp commented Aug 13, 2015

Filings are filed by a committee or a candidate, not both. This means that for every row in the browse filings view, at least one of "Filer Name" and "Candidate Name" is blank. Since only one column can ever be populated for a given row, could we consolidate the two columns into one, and call it something "Filer Name"?

What do you think @LindsayYoung @noahmanger?
@LindsayYoung
Copy link
Contributor

Sounds good, it would be good to make the search look for both candidate and committee, since those would not be 2 separate categories anymore.

@noahmanger
Copy link
Contributor

Or would it better to just have a separate search for candidates? That way we could make use of the typeahead in both cases.

jmcarp added a commit to jmcarp/openFEC-web-app that referenced this issue Sep 2, 2015
@jmcarp
Consolidate committee and candidate filer columns.
b6d12f4 
Since at least one column is always null, consolidate the two columns to
one, and show whichever value is not missing.

[Resolves fecgov#470]
@jmcarp jmcarp mentioned this issue Sep 2, 2015
Merged
@jmcarp jmcarp self-assigned this Sep 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmcarp jmcarp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmcarp @noahmanger @leahbannon @LindsayYoung