Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Election table styling #572

Closed
jmcarp opened this issue Sep 3, 2015 · 6 comments
Closed

Election table styling #572

jmcarp opened this issue Sep 3, 2015 · 6 comments

Comments

@jmcarp
Copy link
Contributor

jmcarp commented Sep 3, 2015

A few minor issues on styling election tables (screenshots below):

  • Value bars for one cell can run into the next
  • The contribution location table is hard to read with too many candidates selected

@noahmanger and @jenniferthibault: I'm guessing you're already aware of these--just filing the issue so we get these in better shape before launch.

screen shot 2015-09-02 at 11 50 53 pm

screen shot 2015-09-02 at 11 51 05 pm

@noahmanger
Copy link
Contributor

I'm fixing the issue of bars running into one another with #581.

Not sure how to handle the issue of too many candidates. Any ideas?

@jmcarp
Copy link
Contributor Author

jmcarp commented Sep 4, 2015

I was hoping that we could just use the scrollX option in DataTables (https://datatables.net/reference/option/scrollX), but I tried, and it seemed to conflict with something in our styles. If that behavior seems reasonable, maybe @noahmanger or @msecret could take a look at getting scrollX to work, or pairing with me to debug.

@jenniferthibault
Copy link
Contributor

Table cells definitely need more padding between each other— not sure if your fix addresses this @noahmanger , but one way I did that in the mockups was to left-align the cell copy with the column title copy, instead of the sorting arrow. Here's an existing mockup for how a scrolling table could look (including the cell alignment), which, I think is what scrollX does, as far as I can tell?

screen shot 2015-09-04 at 4 16 24 pm

@noahmanger
Copy link
Contributor

I'm running into snags trying to get the scrollX working. @jmcarp do you mind taking a look?

@jmcarp
Copy link
Contributor Author

jmcarp commented Sep 14, 2015

@noahmanger I got a decent start on this but could use a second pair of eyes on a few last issues--see description in #661.

@noahmanger
Copy link
Contributor

This has been resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants