Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Browse Candidates: Adding Star for incumbents #647

Closed
PaulClark2 opened this issue Sep 11, 2015 · 3 comments
Closed

Browse Candidates: Adding Star for incumbents #647

PaulClark2 opened this issue Sep 11, 2015 · 3 comments

Comments

@PaulClark2
Copy link

On browse candidate pages, there isn’t a place on the page that tells you what the star means. In cases where a candidate is listed as having more than one election year, the star is meaningless or just confusing. What election year does the star apply to?

https://fec-dev-web.18f.gov/candidates?cycle=2016

stars

@jmcarp
Copy link
Contributor

jmcarp commented Sep 14, 2015

Good catch @PaulClark2. Now that you bring this up, I'm thinking we should drop the incumbent star from this page entirely, and remove the corresponding data from the API--we currently include incumbent_challenge in the candidates endpoint, but without the context of election cycle, the information isn't meaningful.

Thoughts @LindsayYoung @noahmanger?

@PaulClark2
Copy link
Author

👍

@noahmanger
Copy link
Contributor

Sounds good. Let's remove it from here.

jmcarp added a commit to jmcarp/openFEC-web-app that referenced this issue Sep 18, 2015
As discussed in fecgov#647, candidate incumbency status is only defined per
election, and not across a candidate's electoral history. Since the
candidate browse view shows summary information about candidates rather
than per-cycle information, it doesn't make sense to show the incumbency
indicator here.

[Resolves fecgov#647]
@jmcarp jmcarp self-assigned this Sep 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants