Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Fix or remove cycle select for electioneering and communication cost committees #664

Closed
jmcarp opened this issue Sep 14, 2015 · 2 comments
Closed

Comments

@jmcarp
Copy link
Contributor

jmcarp commented Sep 14, 2015

While discussing #653, we noticed that the cycle select dropdown isn't right for electioneering and communication cost committees. We currently identify the relevant election cycles for a committee using F1 and F3 filings, but these committees may rarely file F1 forms and never file F3 forms. I see two non-exclusive fixes here:

  • Fix election cycles for electioneering and communication committees in the API
  • Remove the cycle select for the committees, since they rarely include a large enough number of filings for filters to be useful.

Seems like we should definitely do the first part, but I'd like to get feedback on the second. Pinging @noahmanger @LindsayYoung.

@LindsayYoung
Copy link
Contributor

Would it simply things for committee drop-downs if we only look to see if anything comes up in the filings table for that cycle? Would that work for candidates too?

That would also fix the random F1z adding weird years such as 1988 to Trump's page http://localhost:3000/candidate/P80001571

@noahmanger
Copy link
Contributor

Would that solve the above problem? Either way it makes sense to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants