Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

So that cycle select placement is consistent, move them to the headers of election pages #847

Closed
noahmanger opened this issue Oct 16, 2015 · 3 comments
Assignees

Comments

@noahmanger
Copy link
Contributor

Election pages still have cycle selects in line with the section titles, whereas candidate and committee pages have them in the header area.

I'd like to move them to the same area on candidate pages, but it's complicated by the presence of the map.

At the same time, there's the opportunity to make the titling of these pages more consistent with how we structure candidate and committee pages, where the main heading area is:

# Page title
### Type of page

If / when we re-work these pages to show more office info (along the lines of these wireframes), these areas will be fleshed out more.

Here's suggestions:

Presidential

screen shot 2015-10-15 at 5 06 01 pm

Senate

(Note, the map is currently broken)
screen shot 2015-10-15 at 5 06 25 pm

House

screen shot 2015-10-15 at 5 06 19 pm

@noahmanger
Copy link
Contributor Author

Just realized I've been waiting for feedback on this. @jenniferthibault do you have thoughts about this as an interim solution?

@jenniferthibault
Copy link
Contributor

@noahmanger this makes sense as an interim solution to me, the one small adjustment I'd make is to make sure the underline under the election doesn't bump into the map, it should end at whatever grid column is before the map div. (looking at the third example of California District 2).

Sorry I missed it! I only have email notifications set up for issues I'm tagged in, but maybe I should change that.

@noahmanger
Copy link
Contributor Author

Good catch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants