Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Use consistent limit for reports and totals charts. #106

Merged
merged 1 commit into from
Apr 30, 2015

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Apr 29, 2015

[Resolves https://github.com/18F/openFEC/issues/641]

@LindsayYoung I just saw that you marked this as not a problem, but it's a tiny change anyway. We can close the PR if it's better to wait for quarterly results.

@LindsayYoung
Copy link
Contributor

If you already started, you can go for it. We will need it eventually.

When I said it was not a problem, I just meant it is not as important as the things that are broken or wrong.

Also what would need to scale the charts to work for a wide range of committees. Presidential are going to raise way more than a random committee. We want a scale to look good on both.

@noahmanger
Copy link
Contributor

Yeah I think this is good to include now fwiw.

@noahmanger
Copy link
Contributor

I'm running this locally and not seeing the results limited.
screen shot 2015-04-29 at 11 31 33 am

@jmcarp
Copy link
Contributor Author

jmcarp commented Apr 29, 2015

@noahmanger what are you using for FEC_WEB_API_URL? I'm using https://api.open.fec.gov, and it seems to be working locally.

msecret pushed a commit that referenced this pull request Apr 30, 2015
Use consistent limit for reports and totals charts.
@msecret msecret merged commit b32e02c into fecgov:develop Apr 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants