This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Force HTTPS and HSTS when configured to do so #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also contains a commit that ignores |
Conflicts: __init__.py
|
And, I've updated the branch to resolve the merge conflict. This should be good for review and merge any time. |
| @@ -8,3 +8,4 @@ static/js/app.js | |||
| openfecwebapp/local_config.py | |||
| static/styles/styles.css.map | |||
| app/ | |||
| /.env | |||
There was a problem hiding this comment.
No complaints here, but kind of thing can also go in a global .gitignore, since not everyone uses autoenv. Even though it's great.
There was a problem hiding this comment.
👍 Good call for future stuff, I honestly had not thought of that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
flask-sslifyto force HTTPS and add HSTS, when an environment variable --FEC_FORCE_HTTPS-- is set.As configured, this sets HSTS for 1 year, and includes subdomains. It should only be used on domains where you can guarantee that all subdomains are also available over HTTPS. This could be made configurable with additional variables, but it seemed like the smallest amount of overhead.
The HSTS header will only be sent over HTTPS, and will only take effect if the browser successfully connects over HTTPS. So there's no risk of bricking
localhostor whatever.Fixes https://github.com/18F/openFEC/issues/619.